From: Chanwoo Choi Date: Tue, 22 Aug 2017 07:16:44 +0000 (+0900) Subject: PM / devfreq: Fix memory leak when fail to register device X-Git-Tag: submit/tizen_4.0/20170920.004041~13 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=525e8631a95385765ef80ec6556a8caa3acf81d3;p=platform%2Fkernel%2Flinux-exynos.git PM / devfreq: Fix memory leak when fail to register device When the devfreq_add_device fails to register deivce, the memory leak of devfreq instance happen. So, this patch fix the memory leak issue. Before freeing the devfreq instance checks whether devfreq instance is NULL or not because the device_unregister() frees the devfreq instance when jumping to the 'err_init'. It is to prevent the duplicate the kfee(devfreq). Change-Id: Ic594e6729984fd7227a7efda50db600a6bf1be79 Cc: stable@vger.kernel.org Fixes: ac4b281176a5 ("PM / devfreq: fix duplicated kfree on devfreq pointer") Signed-off-by: Chanwoo Choi Signed-off-by: Myungjoo Ham --- diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 4aa72b5ed660..fb0797b85384 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -566,7 +566,7 @@ struct devfreq *devfreq_add_device(struct device *dev, err = device_register(&devfreq->dev); if (err) { mutex_unlock(&devfreq->lock); - goto err_out; + goto err_dev; } devfreq->trans_table = devm_kzalloc(&devfreq->dev, @@ -612,6 +612,9 @@ err_init: mutex_unlock(&devfreq_list_lock); device_unregister(&devfreq->dev); +err_dev: + if (devfreq) + kfree(devfreq); err_out: return ERR_PTR(err); }