From: Andrei Warkentin Date: Sat, 24 Sep 2011 16:12:30 +0000 (-0400) Subject: mmc: core: ext_csd.raw_* used in comparison but never set X-Git-Tag: v3.2-rc1~129^2~24 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5238acbe36dd5100fb6b035a995ae5fc89dd0708;p=platform%2Fupstream%2Fkernel-adaptation-pc.git mmc: core: ext_csd.raw_* used in comparison but never set f39b2dd9d ("mmc: core: Bus width testing needs to handle suspend/resume") added code to only compare read-only ext_csd fields in bus width testing code, yet it's comparing some fields that are never set. The affected fields are ext_csd.raw_erased_mem_count and ext_csd.raw_partition_support. Signed-off-by: Andrei Warkentin Acked-by: Philip Rakity Cc: Signed-off-by: Chris Ball --- diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index c2334d6..c632b1f 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -359,6 +359,7 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) * card has the Enhanced area enabled. If so, export enhanced * area offset and size to user by adding sysfs interface. */ + card->ext_csd.raw_partition_support = ext_csd[EXT_CSD_PARTITION_SUPPORT]; if ((ext_csd[EXT_CSD_PARTITION_SUPPORT] & 0x2) && (ext_csd[EXT_CSD_PARTITION_ATTRIBUTE] & 0x1)) { u8 hc_erase_grp_sz = @@ -407,6 +408,7 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) card->ext_csd.rst_n_function = ext_csd[EXT_CSD_RST_N_FUNCTION]; } + card->ext_csd.raw_erased_mem_count = ext_csd[EXT_CSD_ERASED_MEM_CONT]; if (ext_csd[EXT_CSD_ERASED_MEM_CONT]) card->erased_byte = 0xFF; else