From: Martin Kaiser Date: Fri, 30 Dec 2022 18:06:43 +0000 (+0100) Subject: staging: r8188eu: remove unnecessary rtw_free_xmitframe call X-Git-Tag: v6.6.17~5455^2~162 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=51cbbb0efe30d0313df66d98b264474a56caea66;p=platform%2Fkernel%2Flinux-rpi.git staging: r8188eu: remove unnecessary rtw_free_xmitframe call There's no need to call rtw_free_xmitframe before we dequeue the first frame. pxmitframe is always NULL at this point, rtw_free_xmitframe will do nothing in this case. Signed-off-by: Martin Kaiser Tested-by: Philipp Hortmann # Edimax N150 Link: https://lore.kernel.org/r/20221230180646.91008-18-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c index cf9779b86b9c..d1af76cc2091 100644 --- a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c +++ b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c @@ -398,9 +398,6 @@ bool rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmit if (!pxmitbuf) return false; - /* 3 1. pick up first frame */ - rtw_free_xmitframe(pxmitpriv, pxmitframe); - pxmitframe = rtw_dequeue_xframe(pxmitpriv, pxmitpriv->hwxmits, pxmitpriv->hwxmit_entry); if (!pxmitframe) { /* no more xmit frame, release xmit buffer */