From: Amol Grover Date: Wed, 19 Feb 2020 09:35:05 +0000 (+0530) Subject: sunrpc: Pass lockdep expression to RCU lists X-Git-Tag: v5.15~4143^2~36 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=51cae673d036a32fe5cca9ec61765aa09e322c59;p=platform%2Fkernel%2Flinux-starfive.git sunrpc: Pass lockdep expression to RCU lists detail->hash_table[] is traversed using hlist_for_each_entry_rcu outside an RCU read-side critical section but under the protection of detail->hash_lock. Hence, add corresponding lockdep expression to silence false-positive warnings, and harden RCU lists. Signed-off-by: Amol Grover Signed-off-by: J. Bruce Fields Signed-off-by: Chuck Lever --- diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c index bd843a81afa0..8a8e3528293c 100644 --- a/net/sunrpc/cache.c +++ b/net/sunrpc/cache.c @@ -113,7 +113,8 @@ static struct cache_head *sunrpc_cache_add_entry(struct cache_detail *detail, spin_lock(&detail->hash_lock); /* check if entry appeared while we slept */ - hlist_for_each_entry_rcu(tmp, head, cache_list) { + hlist_for_each_entry_rcu(tmp, head, cache_list, + lockdep_is_held(&detail->hash_lock)) { if (detail->match(tmp, key)) { if (cache_is_expired(detail, tmp)) { sunrpc_begin_cache_remove_entry(tmp, detail);