From: Milan Broz <mbroz@redhat.com>
Date: Thu, 28 Oct 2010 01:51:30 +0000 (-0600)
Subject: loop: Properly clear sysfs in autoclear mode
X-Git-Tag: v2.6.37-rc1~75^2~6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=51a0bb0c2e614659132fce272c8a1815a12c5c2a;p=profile%2Fcommon%2Fkernel-common.git

loop: Properly clear sysfs in autoclear mode

In autoclear mode bdev is NULL but the sysfs
entry should be destroyed otherwise this warning appears:

WARNING: at fs/sysfs/dir.c:451 sysfs_add_one+0x82/0x95()
sysfs: cannot create duplicate filename '/devices/virtual/block/loop0/loop'

Fixes commit ee86273062cbb310665fe49e1f1937d2cf85b0b9

Signed-off-by: Milan Broz <mbroz@redhat.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
---

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 450c958..1e5284e 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1049,9 +1049,9 @@ static int loop_clr_fd(struct loop_device *lo, struct block_device *bdev)
 	if (bdev)
 		invalidate_bdev(bdev);
 	set_capacity(lo->lo_disk, 0);
+	loop_sysfs_exit(lo);
 	if (bdev) {
 		bd_set_size(bdev, 0);
-		loop_sysfs_exit(lo);
 		/* let user-space know about this change */
 		kobject_uevent(&disk_to_dev(bdev->bd_disk)->kobj, KOBJ_CHANGE);
 	}