From: Colin Cross <ccross@android.com>
Date: Wed, 22 Jun 2011 21:27:37 +0000 (-0700)
Subject: net: ipv4: tcp: Fix crash in tcp_nuke_addr
X-Git-Tag: 2.1b_release~2560
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5199e53b702863e20e15f71908ceba237036fc6e;p=platform%2Fkernel%2Fkernel-mfld-blackbay.git

net: ipv4: tcp: Fix crash in tcp_nuke_addr

ip_route_output_key can return an ERR_PTR, don't dereference it.

Change-Id: I6b86a451b2bdb33873d79b3cf90c11dbe72bc081
Signed-off-by: Colin Cross <ccross@android.com>
---

diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index d1e438f..5eb7af2 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -3328,7 +3328,7 @@ static int tcp_is_local(struct net *net, __be32 addr) {
 	struct rtable *rt;
 	struct flowi4 fl4 = { .daddr = addr };
 	rt = ip_route_output_key(net, &fl4);
-	if (!rt)
+	if (IS_ERR_OR_NULL(rt))
 		return 0;
 	return rt->dst.dev && (rt->dst.dev->flags & IFF_LOOPBACK);
 }