From: Valeriy Van Date: Sun, 28 Aug 2016 09:34:50 +0000 (+0300) Subject: Changes [error localizedDescription] for [error description] in NSLog X-Git-Tag: accepted/tizen/6.0/unified/20201030.111113~1579^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=517be4bfa96277a89fea4b2fbf8b46c457833639;p=platform%2Fupstream%2Fopencv.git Changes [error localizedDescription] for [error description] in NSLog There's no sense to log error messages in user’s locale. Imagine you’re trying to guess what's going on decrypting logs in hebrew, arabic, slavic. localizedDescription is for end user messages, not for logs. --- diff --git a/modules/videoio/src/cap_ios_abstract_camera.mm b/modules/videoio/src/cap_ios_abstract_camera.mm index 702b1f2..425032c 100644 --- a/modules/videoio/src/cap_ios_abstract_camera.mm +++ b/modules/videoio/src/cap_ios_abstract_camera.mm @@ -323,7 +323,7 @@ NSError* error = nil; AVCaptureDeviceInput *input = [AVCaptureDeviceInput deviceInputWithDevice:device error:&error]; if (!input) { - NSLog(@"error creating input %@", [error localizedDescription]); + NSLog(@"error creating input %@", [error description]); } // support for autofocus @@ -333,7 +333,7 @@ device.focusMode = AVCaptureFocusModeContinuousAutoFocus; [device unlockForConfiguration]; } else { - NSLog(@"unable to lock device for autofocus configuration %@", [error localizedDescription]); + NSLog(@"unable to lock device for autofocus configuration %@", [error description]); } } [self.captureSession addInput:input]; @@ -436,7 +436,7 @@ device.focusMode = AVCaptureFocusModeLocked; [device unlockForConfiguration]; } else { - NSLog(@"unable to lock device for locked focus configuration %@", [error localizedDescription]); + NSLog(@"unable to lock device for locked focus configuration %@", [error description]); } } } @@ -450,7 +450,7 @@ device.focusMode = AVCaptureFocusModeContinuousAutoFocus; [device unlockForConfiguration]; } else { - NSLog(@"unable to lock device for autofocus configuration %@", [error localizedDescription]); + NSLog(@"unable to lock device for autofocus configuration %@", [error description]); } } } @@ -464,7 +464,7 @@ device.exposureMode = AVCaptureExposureModeLocked; [device unlockForConfiguration]; } else { - NSLog(@"unable to lock device for locked exposure configuration %@", [error localizedDescription]); + NSLog(@"unable to lock device for locked exposure configuration %@", [error description]); } } } @@ -478,7 +478,7 @@ device.exposureMode = AVCaptureExposureModeContinuousAutoExposure; [device unlockForConfiguration]; } else { - NSLog(@"unable to lock device for autoexposure configuration %@", [error localizedDescription]); + NSLog(@"unable to lock device for autoexposure configuration %@", [error description]); } } } @@ -492,7 +492,7 @@ device.whiteBalanceMode = AVCaptureWhiteBalanceModeLocked; [device unlockForConfiguration]; } else { - NSLog(@"unable to lock device for locked white balance configuration %@", [error localizedDescription]); + NSLog(@"unable to lock device for locked white balance configuration %@", [error description]); } } } @@ -506,7 +506,7 @@ device.whiteBalanceMode = AVCaptureWhiteBalanceModeContinuousAutoWhiteBalance; [device unlockForConfiguration]; } else { - NSLog(@"unable to lock device for auto white balance configuration %@", [error localizedDescription]); + NSLog(@"unable to lock device for auto white balance configuration %@", [error description]); } } }