From: Egor Bogatov <egorbo@gmail.com>
Date: Thu, 12 Nov 2020 04:50:24 +0000 (+0300)
Subject: [RyuJIT] Unroll single-iteration loops (#43947)
X-Git-Tag: submit/tizen/20210909.063632~4657
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=51393bec6f9c375375567ae0ddf8939a6c72bc2f;p=platform%2Fupstream%2Fdotnet%2Fruntime.git

[RyuJIT] Unroll single-iteration loops (#43947)

* Unroll empty loops

* Unroll single-iteration loops

* Update optimizer.cpp

* clean up

* Update optimizer.cpp
---

diff --git a/src/coreclr/src/jit/optimizer.cpp b/src/coreclr/src/jit/optimizer.cpp
index 240e0c5..49ced3a 100644
--- a/src/coreclr/src/jit/optimizer.cpp
+++ b/src/coreclr/src/jit/optimizer.cpp
@@ -3546,19 +3546,7 @@ void Compiler::optUnrollLoops()
         // Check for required flags:
         // LPFLG_DO_WHILE - required because this transform only handles loops of this form
         // LPFLG_CONST - required because this transform only handles full unrolls
-        // LPFLG_SIMD_LIMIT - included here as a heuristic, not for correctness/structural reasons
-        requiredFlags = LPFLG_DO_WHILE | LPFLG_CONST | LPFLG_SIMD_LIMIT;
-
-#ifdef DEBUG
-        if (compStressCompile(STRESS_UNROLL_LOOPS, 50))
-        {
-            // In stress mode, quadruple the size limit, and drop
-            // the restriction that loop limit must be vector element count.
-
-            unrollLimitSz *= 4;
-            requiredFlags &= ~LPFLG_SIMD_LIMIT;
-        }
-#endif
+        requiredFlags = LPFLG_DO_WHILE | LPFLG_CONST;
 
         /* Ignore the loop if we don't have a do-while
         that has a constant number of iterations */
@@ -3647,6 +3635,24 @@ void Compiler::optUnrollLoops()
             continue;
         }
 
+        if (INDEBUG(compStressCompile(STRESS_UNROLL_LOOPS, 50) ||) false)
+        {
+            // In stress mode, quadruple the size limit, and drop
+            // the restriction that loop limit must be vector element count.
+            unrollLimitSz *= 4;
+        }
+        else if (totalIter <= 1)
+        {
+            // No limit for single iteration loops
+            unrollLimitSz = INT_MAX;
+        }
+        else if (!(loopFlags & LPFLG_SIMD_LIMIT))
+        {
+            // Otherwise unroll only if limit is Vector_.Length
+            // (as a heuristic, not for correctness/structural reasons)
+            continue;
+        }
+
         GenTree* incr = incrStmt->GetRootNode();
 
         // Don't unroll loops we don't understand.