From: Christophe JAILLET Date: Fri, 28 Apr 2017 04:51:40 +0000 (-0300) Subject: vb2: Fix an off by one error in 'vb2_plane_vaddr' X-Git-Tag: submit/tizen/20180417.011414~22 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=51018b1e501a1ebda4eefc5791ed4e9a77bdfd5e;p=profile%2Fwearable%2Fplatform%2Fkernel%2Flinux-3.18-exynos7270.git vb2: Fix an off by one error in 'vb2_plane_vaddr' commit 5ebb6dd36c9f5fb37b1077b393c254d70a14cb46 upstream. We should ensure that 'plane_no' is '< vb->num_planes' as done in 'vb2_plane_cookie' just a few lines below. Fixes: e23ccc0ad925 ("[media] v4l: add videobuf2 Video for Linux 2 driver framework") Signed-off-by: Christophe JAILLET Reviewed-by: Sakari Ailus Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman [sw0312.kim: cherry-pick from linux-3.18.y] Signed-off-by: Seung-Woo Kim Change-Id: I78542d0bb4c29c29a1c111cebed7ece2fc6d81cf --- diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index 077f7baa9a9..43fbff61bd2 100644 --- a/drivers/media/v4l2-core/videobuf2-core.c +++ b/drivers/media/v4l2-core/videobuf2-core.c @@ -1140,7 +1140,7 @@ EXPORT_SYMBOL_GPL(vb2_create_bufs); */ void *vb2_plane_vaddr(struct vb2_buffer *vb, unsigned int plane_no) { - if (plane_no > vb->num_planes || !vb->planes[plane_no].mem_priv) + if (plane_no >= vb->num_planes || !vb->planes[plane_no].mem_priv) return NULL; return call_ptr_memop(vb, vaddr, vb->planes[plane_no].mem_priv);