From: Harry Wentland <harry.wentland@amd.com>
Date: Tue, 18 Apr 2017 19:43:22 +0000 (-0400)
Subject: drm/amd/display: Fix memory leak in post_update_surfaces
X-Git-Tag: v5.15~9960^2~23^2~562
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=50f27269b8dd81d73c787dd18ba19a08bec128d3;p=platform%2Fkernel%2Flinux-starfive.git

drm/amd/display: Fix memory leak in post_update_surfaces

Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Acked-by: Harry Wentland <Harry.Wentland@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 64b5216..b1f0a50 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -918,6 +918,7 @@ bool dc_post_update_surfaces_to_stream(struct dc *dc)
 	int i;
 	struct core_dc *core_dc = DC_TO_CORE(dc);
 	struct validate_context *context = dm_alloc(sizeof(struct validate_context));
+	bool result = true;
 
 	if (!context) {
 		dm_error("%s: failed to create validate ctx\n", __func__);
@@ -935,17 +936,19 @@ bool dc_post_update_surfaces_to_stream(struct dc *dc)
 
 	if (!core_dc->res_pool->funcs->validate_bandwidth(core_dc, context)) {
 		BREAK_TO_DEBUGGER();
-		return false;
+		result = false;
+		goto cleanup;
 	}
 
 	core_dc->hwss.set_bandwidth(core_dc, context, true);
 
 	dc_resource_validate_ctx_copy_construct(context, core_dc->current_context);
 
+cleanup:
 	dc_resource_validate_ctx_destruct(context);
 	dm_free(context);
 
-	return true;
+	return result;
 }
 
 bool dc_commit_surfaces_to_stream(