From: Jamie Iles Date: Tue, 11 Jan 2011 12:43:52 +0000 (+0000) Subject: spi/dw_spi: don't treat NULL clk as an error X-Git-Tag: upstream/snapshot3+hdmi~11708^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=50c01fc355c6a97c511d58411f9bc0e4b8fc4659;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git spi/dw_spi: don't treat NULL clk as an error clk_get() returns a struct clk cookie to the driver and some platforms may return NULL if they only support a single clock. clk_get() has only failed if it returns a ERR_PTR() encoded pointer. Signed-off-by: Jamie Iles Signed-off-by: Grant Likely --- diff --git a/drivers/spi/dw_spi_mmio.c b/drivers/spi/dw_spi_mmio.c index db35bd9..2fa012c 100644 --- a/drivers/spi/dw_spi_mmio.c +++ b/drivers/spi/dw_spi_mmio.c @@ -9,6 +9,7 @@ */ #include +#include #include #include #include @@ -68,8 +69,8 @@ static int __devinit dw_spi_mmio_probe(struct platform_device *pdev) } dwsmmio->clk = clk_get(&pdev->dev, NULL); - if (!dwsmmio->clk) { - ret = -ENODEV; + if (IS_ERR(dwsmmio->clk)) { + ret = PTR_ERR(dwsmmio->clk); goto err_irq; } clk_enable(dwsmmio->clk);