From: Leon Romanovsky Date: Sun, 1 Mar 2020 14:44:42 +0000 (+0200) Subject: net/chelsio: Don't set N/A for not available FW X-Git-Tag: v5.10.7~2946^2~254^2~14 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=50ad85c28a165f9d28be7609f44fdab785a3e34f;p=platform%2Fkernel%2Flinux-rpi.git net/chelsio: Don't set N/A for not available FW There is no need to set N/A if FW is not available. Signed-off-by: Leon Romanovsky Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c index f3acdce..2cf3569 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c @@ -174,9 +174,7 @@ static void get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) sizeof(info->bus_info)); info->regdump_len = get_regs_len(dev); - if (!adapter->params.fw_vers) - strcpy(info->fw_version, "N/A"); - else + if (adapter->params.fw_vers) snprintf(info->fw_version, sizeof(info->fw_version), "%u.%u.%u.%u, TP %u.%u.%u.%u", FW_HDR_FW_VER_MAJOR_G(adapter->params.fw_vers),