From: Hwankyu Jhun <h.jhun@samsung.com>
Date: Wed, 28 Sep 2022 01:10:28 +0000 (+0000)
Subject: Fix build break issues
X-Git-Tag: accepted/tizen/unified/20220928.144436~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=509dc6339486343342355b8c94609d9d76500c15;p=platform%2Fcore%2Fappfw%2Fcomponent-based-application.git

Fix build break issues

This patch fixes the build break issues. Currently, this package has
problems about 'invalid application of 'sizeof' to incomplete type'.

Change-Id: Id7d1b14f4d53a6c3db183b5ec088f18ec5108825
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
---

diff --git a/component_based/base/application_base.cc b/component_based/base/application_base.cc
index d2072b6..68e70c0 100644
--- a/component_based/base/application_base.cc
+++ b/component_based/base/application_base.cc
@@ -279,9 +279,11 @@ void ApplicationBase::OnAuxMessage(int type, void* event) {
 }
 
 ApplicationBase::ApplicationBase()
-  : impl_(new Impl(this)) {
+    : impl_(new Impl(this)) {
 }
 
+ApplicationBase::~ApplicationBase() {}
+
 std::string ApplicationBase::GetApplicationID() {
   return impl_->GetApplicationID();
 }
diff --git a/component_based/base/application_base.h b/component_based/base/application_base.h
index be0d56e..2741465 100644
--- a/component_based/base/application_base.h
+++ b/component_based/base/application_base.h
@@ -35,7 +35,7 @@ namespace component_based {
 class EXPORT_API ApplicationBase : public tizen_cpp::AppCoreMultiWindowBase {
  public:
   ApplicationBase();
-  virtual ~ApplicationBase() = default;
+  virtual ~ApplicationBase();
 
   virtual std::map<std::string, std::unique_ptr<Component::FactoryBase>>
       OnCreateFactoryMap() = 0;
diff --git a/component_based/base/component.cc b/component_based/base/component.cc
index d70228a..2d4c167 100644
--- a/component_based/base/component.cc
+++ b/component_based/base/component.cc
@@ -275,11 +275,15 @@ void Component::SetContent(tizen_base::Bundle content) {
   impl_->content_mgr_->SetContent(std::move(content));
 }
 
-Component::Component(std::string comp_id, std::string inst_id, AppCoreMultiWindowBase* app)
-  : AppCoreMultiWindowBase::Context(std::move(comp_id), std::move(inst_id), app),
-  impl_(new Impl(this)) {
+Component::Component(std::string comp_id, std::string inst_id,
+    AppCoreMultiWindowBase* app)
+    : AppCoreMultiWindowBase::Context(std::move(comp_id),
+        std::move(inst_id), app),
+      impl_(new Impl(this)) {
 }
 
+Component::~Component() {}
+
 void Component::Finish() {
   auto* app = GetApp();
   auto* my_app = dynamic_cast<ApplicationBase*>(app);
diff --git a/component_based/base/component.h b/component_based/base/component.h
index 1056cb4..8ec0f63 100644
--- a/component_based/base/component.h
+++ b/component_based/base/component.h
@@ -59,7 +59,7 @@ class EXPORT_API Component : public tizen_cpp::AppCoreMultiWindowBase::Context,
 
   Component(std::string comp_id, std::string inst_id,
       tizen_cpp::AppCoreMultiWindowBase* app);
-  virtual ~Component() = default;
+  virtual ~Component();
 
   virtual void OnDestroy();
   void OnCreate() override;
diff --git a/component_based/base/frame_component.cc b/component_based/base/frame_component.cc
index 4013914..eb49a61 100644
--- a/component_based/base/frame_component.cc
+++ b/component_based/base/frame_component.cc
@@ -31,6 +31,8 @@ FrameComponent::FrameComponent(std::string comp_id, std::string inst_id,
     : Component::Component(std::move(comp_id), std::move(inst_id), app) {
 }
 
+FrameComponent::~FrameComponent() {}
+
 FrameComponent::DisplayStatus FrameComponent::GetDisplayStatus() const {
   app_display_state_e state;
   int r = app_get_display_state(&state);
diff --git a/component_based/base/frame_component.h b/component_based/base/frame_component.h
index e14f1f8..911d4b3 100644
--- a/component_based/base/frame_component.h
+++ b/component_based/base/frame_component.h
@@ -38,7 +38,7 @@ class EXPORT_API FrameComponent : public Component {
 
   FrameComponent(std::string comp_id, std::string inst_id,
       tizen_cpp::AppCoreMultiWindowBase* app);
-  virtual ~FrameComponent() = default;
+  virtual ~FrameComponent();
 
   DisplayStatus GetDisplayStatus() const;
   const IWindow* GetWindow() const;
diff --git a/component_based/base/service_component.cc b/component_based/base/service_component.cc
index 3f2725d..eeb913f 100644
--- a/component_based/base/service_component.cc
+++ b/component_based/base/service_component.cc
@@ -27,6 +27,8 @@ ServiceComponent::ServiceComponent(std::string comp_id, std::string inst_id,
   : Component::Component(std::move(comp_id), std::move(inst_id), app) {
 }
 
+ServiceComponent::~ServiceComponent() {}
+
 void ServiceComponent::OnStart(AppControl control, bool restarted) {
   Component::OnStart(control, restarted);
   tizen_base::Bundle content = GetContent();
diff --git a/component_based/base/service_component.h b/component_based/base/service_component.h
index 667f994..c714150 100644
--- a/component_based/base/service_component.h
+++ b/component_based/base/service_component.h
@@ -31,7 +31,7 @@ class EXPORT_API ServiceComponent : public Component {
  public:
   ServiceComponent(std::string comp_id, std::string inst_id,
       tizen_cpp::AppCoreMultiWindowBase* app);
-  virtual ~ServiceComponent() = default;
+  virtual ~ServiceComponent();
 
   virtual void OnStartCommand(AppControl app_control, bool restarted);