From: Colin Ian King Date: Thu, 15 Jul 2021 14:15:31 +0000 (+0100) Subject: regulator: rt6245: make a const array func_base static, makes object smaller X-Git-Tag: accepted/tizen/unified/20230118.172025~6187^2~22 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=508f8ccd993d1ff5c9a3092f179f33bd7a825bac;p=platform%2Fkernel%2Flinux-rpi.git regulator: rt6245: make a const array func_base static, makes object smaller Don't populate the const array func_base on the stack but instead it static. Makes the object code smaller by 55 bytes: Before: text data bss dec hex filename 6422 3216 64 9702 25e6 drivers/regulator/rt6245-regulator.o After: text data bss dec hex filename 6303 3280 64 9647 25af drivers/regulator/rt6245-regulator.o Reduction of 55 bytes (gcc version 10.3.0) Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20210715141531.27672-1-colin.king@canonical.com Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/rt6245-regulator.c b/drivers/regulator/rt6245-regulator.c index d3299a7..cb22a20 100644 --- a/drivers/regulator/rt6245-regulator.c +++ b/drivers/regulator/rt6245-regulator.c @@ -144,7 +144,7 @@ static int rt6245_init_device_properties(struct device *dev) static int rt6245_reg_write(void *context, unsigned int reg, unsigned int val) { struct i2c_client *i2c = context; - const u8 func_base[] = { 0x6F, 0x73, 0x78, 0x61, 0x7C, 0 }; + static const u8 func_base[] = { 0x6F, 0x73, 0x78, 0x61, 0x7C, 0 }; unsigned int code, bit_count; code = func_base[reg];