From: Kevin Sawicki Date: Tue, 25 Apr 2017 21:20:39 +0000 (-0700) Subject: Don't allow webPreferences to be overrideden in features string X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=507f60e33e656248aeb40cc0d5fd8065a7dde5e4;p=platform%2Fframework%2Fweb%2Fcrosswalk-tizen.git Don't allow webPreferences to be overrideden in features string --- diff --git a/lib/browser/guest-window-manager.js b/lib/browser/guest-window-manager.js index 33ec15a..e668a31 100644 --- a/lib/browser/guest-window-manager.js +++ b/lib/browser/guest-window-manager.js @@ -202,6 +202,10 @@ ipcMain.on('ELECTRON_GUEST_WINDOW_MANAGER_WINDOW_OPEN', (event, url, frameName, if (value === undefined) { additionalFeatures.push(key) } else { + // Don't allow webPreferences to be set since it must be an object + // that cannot be directly overridden + if (key === 'webPreferences') return + if (webPreferences.includes(key)) { if (options.webPreferences == null) { options.webPreferences = {}