From: Ilho Kim <ilho159.kim@samsung.com>
Date: Fri, 7 Aug 2020 03:52:01 +0000 (+0900)
Subject: Fix the behavior sending the signal
X-Git-Tag: submit/tizen/20200810.091347~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5064aab1e7ed1d9bc45d5f86fb9ef21ffd8eba40;p=platform%2Fcore%2Fappfw%2Fapp-installers.git

Fix the behavior sending the signal

If the installer failed to parse package's id
installer should send start signal with empty pkgid

Change-Id: I861c4b3b723035e75d364f11e899228f8a3d7bc0
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
---

diff --git a/src/common/installer/app_installer.cc b/src/common/installer/app_installer.cc
index a8d0b6b8..cf6e88f3 100644
--- a/src/common/installer/app_installer.cc
+++ b/src/common/installer/app_installer.cc
@@ -833,12 +833,12 @@ void AppInstaller::HandleStepError(Step::Status result,
                  context_->pkgid.get());
 }
 
-bool AppInstaller::SendStartIfNotSent() {
+bool AppInstaller::SendStartIfNotSent(bool is_skippable) {
   if (!pi_)
     return false;
 
-  if (pi_->state() != PkgmgrSignal::State::NOT_SENT ||
-      context_->pkgid.get().empty())
+  if ((pi_->state() != PkgmgrSignal::State::NOT_SENT ||
+      context_->pkgid.get().empty()) && is_skippable)
     return true;
 
   // set request type before sending start signal
@@ -852,7 +852,7 @@ bool AppInstaller::SendStartIfNotSent() {
 
 void AppInstaller::SendProgress(int progress) {
   // send START signal as soon as possible if not sent
-  if (!SendStartIfNotSent())
+  if (!SendStartIfNotSent(true))
     return;
 
   // send installation progress
@@ -861,7 +861,7 @@ void AppInstaller::SendProgress(int progress) {
 }
 
 void AppInstaller::SendFinished(Step::Status process_status) {
-  if (!SendStartIfNotSent())
+  if (!SendStartIfNotSent(false))
     return;
 
   pi_->SendFinished(process_status,
diff --git a/src/common/installer/app_installer.h b/src/common/installer/app_installer.h
index 8996fb8c..b0e917d8 100644
--- a/src/common/installer/app_installer.h
+++ b/src/common/installer/app_installer.h
@@ -291,7 +291,7 @@ class AppInstaller {
   // data used to send signal
   std::unique_ptr<PkgmgrSignal> pi_;
 
-  bool SendStartIfNotSent();
+  bool SendStartIfNotSent(bool is_skippable);
   void SendProgress(int progress);
   void SendFinished(Step::Status status);
   Step::Status SafeExecute(std::unique_ptr<Step> const& step_ptr,