From: sungwook79.park <sungwook79.park@samsung.com>
Date: Thu, 7 Jul 2016 07:48:57 +0000 (+0900)
Subject: enhance line coverage rate
X-Git-Tag: submit/tizen/20160707.080158~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5061805dda810a259371dae85c2e3a3c3abf573f;p=platform%2Fcore%2Fapi%2Finputmethod-manager.git

enhance line coverage rate

Change-Id: Ia5c4e0779daa2aea332495d7080966a340bd8ba7
Signed-off-by: sungwook79.park <sungwook79.park@samsung.com>
---

diff --git a/src/inputmethod_manager.cpp b/src/inputmethod_manager.cpp
index 977fc99..3105996 100755
--- a/src/inputmethod_manager.cpp
+++ b/src/inputmethod_manager.cpp
@@ -34,14 +34,11 @@ ime_manager_error_e _check_privilege()
     ime_manager_error_e ret = IME_MANAGER_ERROR_NONE;
 
     if (inputmethod_cynara_initialize() == false) {
-        LOGE("inputmethod_cynara_initialize () == false");
         return IME_MANAGER_ERROR_PERMISSION_DENIED;
     }
 
     snprintf(uid, 16, "%d", getuid());
     if (check_privilege(uid, IME_MANAGER_PRIVILEGE) == false) {
-        LOGE("check_privilege(uid, IME_MANAGER_PRIVILEGE) == false");
-        LOGE("uid : %s.", uid);
         ret = IME_MANAGER_ERROR_PERMISSION_DENIED;
     }
 
@@ -56,7 +53,6 @@ int ime_manager_show_ime_list(void)
 
     retVal = _check_privilege();
     if (retVal != IME_MANAGER_ERROR_NONE) {
-        LOGE("_check_privilege returned %d.", retVal);
         return retVal;
     }
 
@@ -64,7 +60,6 @@ int ime_manager_show_ime_list(void)
     if (ret == 0) {
         return IME_MANAGER_ERROR_NONE;
     } else {
-        LOGW("IME_MANAGER_ERROR_OPERATION_FAILED");
         return IME_MANAGER_ERROR_OPERATION_FAILED;
     }
 }
@@ -75,7 +70,6 @@ int ime_manager_show_ime_selector(void)
 
     retVal = _check_privilege();
     if (retVal != IME_MANAGER_ERROR_NONE) {
-        LOGE("_check_privilege returned %d.", retVal);
         return retVal;
     }
 
@@ -83,7 +77,6 @@ int ime_manager_show_ime_selector(void)
     if (ret == 0) {
         return IME_MANAGER_ERROR_NONE;
     } else {
-        LOGW("IME_MANAGER_ERROR_OPERATION_FAILED");
         return IME_MANAGER_ERROR_OPERATION_FAILED;
     }
 }
@@ -94,18 +87,15 @@ int ime_manager_is_ime_enabled(const char *app_id, bool *enabled)
 
     retVal = _check_privilege();
     if (retVal != IME_MANAGER_ERROR_NONE) {
-        LOGE("_check_privilege returned %d.", retVal);
         return retVal;
     }
 
     if (!app_id || !enabled) {
-        LOGW("IME_MANAGER_ERROR_INVALID_PARAMETER");
         return IME_MANAGER_ERROR_INVALID_PARAMETER;
     }
 
     int ret = isf_control_is_ime_enabled(app_id, enabled);
     if (ret < 0) {
-        LOGW("IME_MANAGER_ERROR_OPERATION_FAILED");
         return IME_MANAGER_ERROR_OPERATION_FAILED;
     }
 
@@ -118,18 +108,15 @@ int ime_manager_get_active_ime(char **app_id)
 
     retVal = _check_privilege();
     if (retVal != IME_MANAGER_ERROR_NONE) {
-        LOGE("_check_privilege returned %d.", retVal);
         return retVal;
     }
 
     if (!app_id) {
-        LOGW("IME_MANAGER_ERROR_INVALID_PARAMETER");
         return IME_MANAGER_ERROR_INVALID_PARAMETER;
     }
 
     int ret = isf_control_get_active_ime(app_id);
     if (ret < 0) {
-        LOGW("IME_MANAGER_ERROR_OPERATION_FAILED");
         return IME_MANAGER_ERROR_OPERATION_FAILED;
     }
 
@@ -145,7 +132,6 @@ int ime_manager_get_enabled_ime_count(void)
     retVal = _check_privilege();
     if (retVal != IME_MANAGER_ERROR_NONE) {
         set_last_result(IME_MANAGER_ERROR_PERMISSION_DENIED);
-        LOGE("_check_privilege returned %d.", retVal);
         return enable_ime_count;
     }
 
diff --git a/src/privilege_checker.cpp b/src/privilege_checker.cpp
index b002fad..014bb56 100644
--- a/src/privilege_checker.cpp
+++ b/src/privilege_checker.cpp
@@ -52,9 +52,7 @@ check_privilege(const char *uid, const char *privilege)
 
     fp = fopen("/proc/self/attr/current", "r");
     if (fp != NULL) {
-        if (fread(smack_label, 1, sizeof(smack_label), fp) <= 0)
-            LOGW("Error : fread");
-
+        if (fread(smack_label, 1, sizeof(smack_label), fp) <= 0);
         fclose(fp);
     }