From: Vinson Lee Date: Sat, 28 Sep 2013 04:46:33 +0000 (-0700) Subject: draw: Add a null check for draw. X-Git-Tag: upstream/10.0.5~1181 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=505a6de7fc5e281d0faf7950cc97fbe88cd9bbf4;p=platform%2Fupstream%2Fmesa.git draw: Add a null check for draw. There is an earlier null check for draw so draw could be null here as well. Fixes "Dereference after null check" defect reported by Coverity. Signed-off-by: Vinson Lee Reviewed-by: Brian Paul --- diff --git a/src/gallium/auxiliary/draw/draw_pipe_unfilled.c b/src/gallium/auxiliary/draw/draw_pipe_unfilled.c index 7a88ce0..8cba07c 100644 --- a/src/gallium/auxiliary/draw/draw_pipe_unfilled.c +++ b/src/gallium/auxiliary/draw/draw_pipe_unfilled.c @@ -237,7 +237,7 @@ draw_unfilled_prepare_outputs( struct draw_context *draw, boolean is_unfilled = (rast && (rast->fill_front != PIPE_POLYGON_MODE_FILL || rast->fill_back != PIPE_POLYGON_MODE_FILL)); - const struct draw_fragment_shader *fs = draw->fs.fragment_shader; + const struct draw_fragment_shader *fs = draw ? draw->fs.fragment_shader : 0; if (is_unfilled && fs && fs->info.uses_frontface) { unfilled->face_slot = draw_alloc_extra_vertex_attrib(