From: James Stevenson Date: Thu, 25 Feb 2016 22:36:14 +0000 (+0000) Subject: bus: Prevent gst_bus_add_watch_full_unlocked from a segfault if priv->poll == NULL X-Git-Tag: 1.10.4~382 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5048155f575856b0a5a07d95dac72b90bee9d7bb;p=platform%2Fupstream%2Fgstreamer.git bus: Prevent gst_bus_add_watch_full_unlocked from a segfault if priv->poll == NULL This happens if the process runs out of file descriptors. Better print a critical warning instead of just crashing. https://bugzilla.gnome.org/show_bug.cgi?id=762702 --- diff --git a/gst/gstbus.c b/gst/gstbus.c index 237507f..d24a935 100644 --- a/gst/gstbus.c +++ b/gst/gstbus.c @@ -892,6 +892,10 @@ gst_bus_add_watch_full_unlocked (GstBus * bus, gint priority, } source = gst_bus_create_watch (bus); + if (!source) { + g_critical ("Creating bus watch failed"); + return 0; + } if (priority != G_PRIORITY_DEFAULT) g_source_set_priority (source, priority);