From: Hans Verkuil Date: Tue, 7 Jul 2020 13:36:47 +0000 (+0200) Subject: sun4i-csi: call _vb2_fop_release instead of v4l2_fh_release X-Git-Tag: v5.15~3158^2~185 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=503ebad4b5d7883ab8476d95f0e2aa77bc56f91e;p=platform%2Fkernel%2Flinux-starfive.git sun4i-csi: call _vb2_fop_release instead of v4l2_fh_release This driver didn't call _vb2_fop_release in the sun4i_csi_release function. Without that call the vb2 queue is not properly canceled and buffers may not be freed. Signed-off-by: Hans Verkuil Acked-by: Maxime Ripard Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c index 06bf0d1..8f4e254 100644 --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c @@ -242,7 +242,8 @@ static int sun4i_csi_release(struct file *file) mutex_lock(&csi->lock); - v4l2_fh_release(file); + _vb2_fop_release(file, NULL); + v4l2_pipeline_pm_put(&csi->vdev.entity); pm_runtime_put(csi->dev);