From: Ville Syrjälä Date: Fri, 24 Jan 2020 20:02:29 +0000 (+0200) Subject: drm/edid: Add a FIXME about DispID CEA data block revision X-Git-Tag: v5.10.7~2352^2~6^2~239 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=5036c0d0f280a10963b01230ee12f3cac014eac1;p=platform%2Fkernel%2Flinux-rpi.git drm/edid: Add a FIXME about DispID CEA data block revision I don't understand what the DispID CEA data block revision means. The spec doesn't say. I guess some DispID must have a value of >= 3 in there or else we generally wouldn't even parse the CEA data blocks. Or does all this code actually not do anything? Cc: Andres Rodriguez Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20200124200231.10517-6-ville.syrjala@linux.intel.com Reviewed-by: Andres Rodriguez Reviewed-by: Uma Shankar --- diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 61f7737..097e54a 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3993,6 +3993,13 @@ cea_db_tag(const u8 *db) static int cea_revision(const u8 *cea) { + /* + * FIXME is this correct for the DispID variant? + * The DispID spec doesn't really specify whether + * this is the revision of the CEA extension or + * the DispID CEA data block. And the only value + * given as an example is 0. + */ return cea[1]; }