From: Srivatsa S. Bhat Date: Sat, 19 Nov 2011 13:37:57 +0000 (+0100) Subject: PM / Suspend: Fix bug in suspend statistics update X-Git-Tag: v3.2-rc3~28^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=501a708f18ef911328ffd39f39738b8a7862aa8e;p=profile%2Fcommon%2Fplatform%2Fkernel%2Flinux-artik7.git PM / Suspend: Fix bug in suspend statistics update After commit 2a77c46de1e3dace73745015635ebbc648eca69c (PM / Suspend: Add statistics debugfs file for suspend to RAM) a missing pair of braces inside the state_store() function causes even invalid arguments to suspend to be wrongly treated as failed suspend attempts. Fix this. [rjw: Put the hash/subject of the buggy commit into the changelog.] Signed-off-by: Srivatsa S. Bhat Signed-off-by: Rafael J. Wysocki --- diff --git a/kernel/power/main.c b/kernel/power/main.c index 71f49fe..36e0f09 100644 --- a/kernel/power/main.c +++ b/kernel/power/main.c @@ -290,13 +290,14 @@ static ssize_t state_store(struct kobject *kobj, struct kobj_attribute *attr, if (*s && len == strlen(*s) && !strncmp(buf, *s, len)) break; } - if (state < PM_SUSPEND_MAX && *s) + if (state < PM_SUSPEND_MAX && *s) { error = enter_state(state); if (error) { suspend_stats.fail++; dpm_save_failed_errno(error); } else suspend_stats.success++; + } #endif Exit: