From: Chris Wilson Date: Fri, 25 Nov 2016 13:17:15 +0000 (+0000) Subject: drm/i915: Add is-completed assert to request retire entrypoint X-Git-Tag: v4.14-rc1~674^2~37^2~773 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4ffd6e0cfe1816fced8ab8d2612e1edde81aac2a;p=platform%2Fkernel%2Flinux-rpi3.git drm/i915: Add is-completed assert to request retire entrypoint While we will check that the request is completed prior to being retired, by placing an assert that the request is complete at the entrypoint of the function we can more clearly document the function's preconditions. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Link: http://patchwork.freedesktop.org/patch/msgid/20161125131718.20978-1-chris@chris-wilson.co.uk --- diff --git a/drivers/gpu/drm/i915/i915_gem_request.c b/drivers/gpu/drm/i915/i915_gem_request.c index 8290459..bd7b21f 100644 --- a/drivers/gpu/drm/i915/i915_gem_request.c +++ b/drivers/gpu/drm/i915/i915_gem_request.c @@ -281,6 +281,8 @@ void i915_gem_request_retire_upto(struct drm_i915_gem_request *req) struct drm_i915_gem_request *tmp; lockdep_assert_held(&req->i915->drm.struct_mutex); + GEM_BUG_ON(!i915_gem_request_completed(req)); + if (list_empty(&req->link)) return;