From: Kumar Sanghvi Date: Tue, 18 Feb 2014 12:26:11 +0000 (+0530) Subject: cxgb4: LE-Workaround is not atomic in firmware X-Git-Tag: v3.15-rc1~113^2~315^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4fe44dd77602fef804561c46ad10b988ee2859ac;p=platform%2Fkernel%2Flinux-exynos.git cxgb4: LE-Workaround is not atomic in firmware The LE workaround in firmware is not atomic and fw_ofld_connection_wrs must not interleave. Therefore, when the workaround is enabled, we need to send all ctrlq WRs on a single ctrl queue. Based on original work by Santosh Rastapur Signed-off-by: Kumar Sanghvi Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c index 47ffa64..23dbe28 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/sge.c +++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c @@ -1467,8 +1467,12 @@ static inline int ofld_send(struct adapter *adap, struct sk_buff *skb) { unsigned int idx = skb_txq(skb); - if (unlikely(is_ctrl_pkt(skb))) + if (unlikely(is_ctrl_pkt(skb))) { + /* Single ctrl queue is a requirement for LE workaround path */ + if (adap->tids.nsftids) + idx = 0; return ctrl_xmit(&adap->sge.ctrlq[idx], skb); + } return ofld_xmit(&adap->sge.ofldtxq[idx], skb); }