From: Keith Whitwell <keith@tungstengraphics.com>
Date: Wed, 20 Sep 2006 15:04:05 +0000 (+0000)
Subject: Add a comment about the interactions of negative pitches, overlapping
X-Git-Tag: mesa-7.8~7050
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4f17378ec32844a483c45252ebd76fa892b8aca7;p=platform%2Fupstream%2Fmesa.git

Add a comment about the interactions of negative pitches, overlapping
blits and the different ways of specifying a blit on this hardware.
---

diff --git a/src/mesa/drivers/dri/i965/intel_blit.c b/src/mesa/drivers/dri/i965/intel_blit.c
index c57618b..c0d6983 100644
--- a/src/mesa/drivers/dri/i965/intel_blit.c
+++ b/src/mesa/drivers/dri/i965/intel_blit.c
@@ -288,6 +288,14 @@ void intelEmitCopyBlit( struct intel_context *intel,
 
    /* Initial y values don't seem to work with negative pitches.  If
     * we adjust the offsets manually (below), it seems to work fine.
+    *
+    * However, on broadwater at least, only the top version works
+    * correctly with overlapping blits.  Luckily we don't need
+    * negative pitches and overlapping blits at the same time, as far
+    * as I know anyhow.
+    *
+    * Further, the current i965 driver never requires negative
+    * pitches, so just use the old-style blits for now.
     */
    if (1) {
       BEGIN_BATCH(8, INTEL_BATCH_NO_CLIPRECTS);