From: Uwe Kleine-König Date: Thu, 26 Nov 2020 07:23:31 +0000 (+0100) Subject: i2c: remove check that can never be true X-Git-Tag: v5.15~2210^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4e970a0ada5299d017a4263074f725227c2d2852;p=platform%2Fkernel%2Flinux-starfive.git i2c: remove check that can never be true A driver remove callback is only called if the device was bound before. So it's sure that both dev and dev->driver are valid and dev is an i2c device. If the check fails something louder than "return 0" might be appropriate because the problem is grave (something like memory corruption), otherwise the check is useless. Signed-off-by: Uwe Kleine-König Signed-off-by: Wolfram Sang --- diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 6528d9e..63ebf72 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -549,12 +549,9 @@ put_sync_adapter: static int i2c_device_remove(struct device *dev) { - struct i2c_client *client = i2c_verify_client(dev); + struct i2c_client *client = to_i2c_client(dev); struct i2c_driver *driver; - if (!client || !dev->driver) - return 0; - driver = to_i2c_driver(dev->driver); if (driver->remove) { int status;