From: Chris J Arges Date: Wed, 2 Nov 2016 14:13:42 +0000 (-0500) Subject: igb: Workaround for igb i210 firmware issue X-Git-Tag: v4.14-rc1~1433^2~82^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4e684f59d760a2c7c716bb60190783546e2d08a1;p=platform%2Fkernel%2Flinux-rpi.git igb: Workaround for igb i210 firmware issue Sometimes firmware may not properly initialize I347AT4_PAGE_SELECT causing the probe of an igb i210 NIC to fail. This patch adds an addition zeroing of this register during igb_get_phy_id to workaround this issue. Thanks for Jochen Henneberg for the idea and original patch. Signed-off-by: Chris J Arges Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c index 5b54254..569ee25 100644 --- a/drivers/net/ethernet/intel/igb/e1000_phy.c +++ b/drivers/net/ethernet/intel/igb/e1000_phy.c @@ -77,6 +77,10 @@ s32 igb_get_phy_id(struct e1000_hw *hw) s32 ret_val = 0; u16 phy_id; + /* ensure PHY page selection to fix misconfigured i210 */ + if (hw->mac.type == e1000_i210) + phy->ops.write_reg(hw, I347AT4_PAGE_SELECT, 0); + ret_val = phy->ops.read_reg(hw, PHY_ID1, &phy_id); if (ret_val) goto out;