From: Ursula Braun Date: Tue, 21 Nov 2017 12:23:53 +0000 (+0100) Subject: net/smc: use sk_rcvbuf as start for rmb creation X-Git-Tag: v4.19~2099^2~9^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4e1061f4a2bba1669c7297455c73ddafbebf2b12;p=platform%2Fkernel%2Flinux-rpi.git net/smc: use sk_rcvbuf as start for rmb creation Commit 3e034725c0d8 ("net/smc: common functions for RMBs and send buffers") merged handling of SMC receive and send buffers. It introduced sk_buf_size as merged start value for size determination. But since sk_buf_size is not used at all, sk_sndbuf is erroneously used as start for rmb creation. This patch makes sure, sk_buf_size is really used as intended, and sk_rcvbuf is used as start value for rmb creation. Fixes: 3e034725c0d8 ("net/smc: common functions for RMBs and send buffers") Signed-off-by: Ursula Braun Reviewed-by: Hans Wippel Signed-off-by: David S. Miller --- diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c index 2578fbd..3b5e5d4 100644 --- a/net/smc/smc_core.c +++ b/net/smc/smc_core.c @@ -575,7 +575,7 @@ static int __smc_buf_create(struct smc_sock *smc, bool is_rmb) /* use socket send buffer size (w/o overhead) as start value */ sk_buf_size = smc->sk.sk_sndbuf / 2; - for (bufsize_short = smc_compress_bufsize(smc->sk.sk_sndbuf / 2); + for (bufsize_short = smc_compress_bufsize(sk_buf_size); bufsize_short >= 0; bufsize_short--) { if (is_rmb) {