From: Dan Carpenter <error27@gmail.com>
Date: Tue, 23 Aug 2011 19:15:35 +0000 (+0300)
Subject: bcma: signedness bug in bcma_get_next_core()
X-Git-Tag: v3.2-rc1~129^2~254^2~242
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4e0d8cc1006b889909a87f824943bad9a56358e8;p=platform%2Fkernel%2Flinux-3.10.git

bcma: signedness bug in bcma_get_next_core()

The u32 would never be less than zero so the error handling would
break.  I changed it to s32 to match how bcma_erom_get_mst_port() is
declared.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---

diff --git a/drivers/bcma/scan.c b/drivers/bcma/scan.c
index 0ea390f..cad9948 100644
--- a/drivers/bcma/scan.c
+++ b/drivers/bcma/scan.c
@@ -281,7 +281,7 @@ static int bcma_get_next_core(struct bcma_bus *bus, u32 __iomem **eromptr,
 
 	/* get & parse master ports */
 	for (i = 0; i < ports[0]; i++) {
-		u32 mst_port_d = bcma_erom_get_mst_port(bus, eromptr);
+		s32 mst_port_d = bcma_erom_get_mst_port(bus, eromptr);
 		if (mst_port_d < 0)
 			return -EILSEQ;
 	}