From: Juan Hoyos <juan.hoyos@microsoft.com>
Date: Sat, 21 Mar 2020 06:17:29 +0000 (-0700)
Subject: Disable Microsoft.Diagnostics.NETCore.Client.WriteAllDumpTypesTest (#934)
X-Git-Tag: submit/tizen_5.5/20200504.045052~11^2^2~51
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4dd2878d0c679482ad9beefb349a3f0f7e9975e8;p=platform%2Fcore%2Fdotnet%2Fdiagnostics.git

Disable Microsoft.Diagnostics.NETCore.Client.WriteAllDumpTypesTest (#934)

Given dotnet/diagnostics#913 I'm disabling this test until it can get investigated.

This path is exerted in @d366deb src/Tools/dotnet-dump/Dumper.cs:77 and dotnet-dump has several tests for collecting dump types, so even if we disable the test, we will still get some coverage.
---

diff --git a/src/tests/Microsoft.Diagnostics.NETCore.Client/WriteDumpTests.cs b/src/tests/Microsoft.Diagnostics.NETCore.Client/WriteDumpTests.cs
index f438f882c..fb06c1528 100644
--- a/src/tests/Microsoft.Diagnostics.NETCore.Client/WriteDumpTests.cs
+++ b/src/tests/Microsoft.Diagnostics.NETCore.Client/WriteDumpTests.cs
@@ -54,7 +54,7 @@ namespace Microsoft.Diagnostics.NETCore.Client
         /// <summary>
         /// A test that writes all the different types of dump file
         /// </summary>
-        [Fact]
+        [Fact(Skip = "Test often times out in official builds/PRs. See https://github.com/dotnet/diagnostics/issues/913")]
         public void WriteAllDumpTypesTest()
         {
             var normalDumpPath = "./myDump-normal.dmp";