From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Fri, 9 Jun 2017 11:41:29 +0000 (+0200)
Subject: gpio: mockup: don't return magic numbers from probe()
X-Git-Tag: v4.14-rc1~555^2~19
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4dc9d76c983db100ec91b65f6cee804871e5102f;p=platform%2Fkernel%2Flinux-rpi.git

gpio: mockup: don't return magic numbers from probe()

When the requested number of GPIO lines is 0, return -EINVAL, not
-1 which is -EPERM.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---

diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index 0cb6cba..ab2d38e 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -369,7 +369,7 @@ static int gpio_mockup_probe(struct platform_device *pdev)
 			ret = gpio_mockup_add(dev, &chips[i],
 					      chip_name, base, ngpio);
 		} else {
-			ret = -1;
+			ret = -EINVAL;
 		}
 
 		if (ret) {