From: Seung-Woo Kim <sw0312.kim@samsung.com>
Date: Fri, 29 Jan 2021 10:27:56 +0000 (+0900)
Subject: halapi: Check enum range for backend_abi_min_version
X-Git-Tag: submit/tizen/20210201.032626^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4dbcdebdac3dc54df2c4fe0efaa32cbccabbf4f8;p=platform%2Fhal%2Fapi%2Fcommon.git

halapi: Check enum range for backend_abi_min_version

To avoid out-of-bounds access of version str array, check value
range for data->backend_abi_min_version always.

Change-Id: I3fb05ab9a27394f817937b589ce7751da0467a69
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---

diff --git a/src/hal-api-common.c b/src/hal-api-common.c
index c4e2372..c476024 100644
--- a/src/hal-api-common.c
+++ b/src/hal-api-common.c
@@ -227,6 +227,13 @@ int hal_common_check_backend_abi_version(enum hal_module module,
 		if (g_platform_curr_abi_version != data->platform_abi_version)
 			continue;
 
+		if (data->backend_min_abi_version <= HAL_ABI_VERSION_UNKNOWN ||
+			data->backend_min_abi_version >= HAL_ABI_VERSION_END) {
+			_E("wrong data in backend_min_abi_version %d\n",
+				data->backend_min_abi_version);
+			return TIZEN_ERROR_INVALID_PARAMETER;
+		}
+
 		if (abi_version <= data->platform_abi_version
 				&& abi_version >= data->backend_min_abi_version)
 			return TIZEN_ERROR_NONE;