From: Gao Xiang Date: Tue, 1 Aug 2023 01:47:37 +0000 (+0800) Subject: erofs: drop unnecessary WARN_ON() in erofs_kill_sb() X-Git-Tag: v6.6.17~4270^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4da3c7183e186afe8196160f16d5a0248a24e45d;p=platform%2Fkernel%2Flinux-rpi.git erofs: drop unnecessary WARN_ON() in erofs_kill_sb() Previously, .kill_sb() will be called only after fill_super fails. It will be changed [1]. Besides, checking for s_magic in erofs_kill_sb() is unnecessary from any point of view. Let's get rid of it now. [1] https://lore.kernel.org/r/20230731-flugbereit-wohnlage-78acdf95ab7e@brauner Signed-off-by: Gao Xiang Reviewed-by: Christoph Hellwig Acked-by: Christian Brauner Link: https://lore.kernel.org/r/20230801014737.28614-1-hsiangkao@linux.alibaba.com --- diff --git a/fs/erofs/super.c b/fs/erofs/super.c index 9d6a3c6..566f68d 100644 --- a/fs/erofs/super.c +++ b/fs/erofs/super.c @@ -889,8 +889,6 @@ static void erofs_kill_sb(struct super_block *sb) { struct erofs_sb_info *sbi; - WARN_ON(sb->s_magic != EROFS_SUPER_MAGIC); - /* pseudo mount for anon inodes */ if (sb->s_flags & SB_KERNMOUNT) { kill_anon_super(sb);