From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 28 Feb 2020 09:25:54 +0000 (+0300)
Subject: mtd: lpddr: Fix a double free in probe()
X-Git-Tag: v5.10.7~2913^2~8
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4da0ea71ea934af18db4c63396ba2af1a679ef02;p=platform%2Fkernel%2Flinux-rpi.git

mtd: lpddr: Fix a double free in probe()

This function is only called from lpddr_probe().  We free "lpddr" both
here and in the caller, so it's a double free.  The best place to free
"lpddr" is in lpddr_probe() so let's delete this one.

Fixes: 8dc004395d5e ("[MTD] LPDDR qinfo probing.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200228092554.o57igp3nqhyvf66t@kili.mountain
---

diff --git a/drivers/mtd/lpddr/lpddr_cmds.c b/drivers/mtd/lpddr/lpddr_cmds.c
index 1efc643..9341a8a 100644
--- a/drivers/mtd/lpddr/lpddr_cmds.c
+++ b/drivers/mtd/lpddr/lpddr_cmds.c
@@ -68,7 +68,6 @@ struct mtd_info *lpddr_cmdset(struct map_info *map)
 	shared = kmalloc_array(lpddr->numchips, sizeof(struct flchip_shared),
 						GFP_KERNEL);
 	if (!shared) {
-		kfree(lpddr);
 		kfree(mtd);
 		return NULL;
 	}