From: Colin Ian King Date: Thu, 4 Feb 2021 17:27:48 +0000 (+0000) Subject: HID: lg-g15: make a const array static, makes object smaller X-Git-Tag: accepted/tizen/unified/20230118.172025~7762^2~4^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4d30083301488199a9cef4ffa6ff15149474ebca;p=platform%2Fkernel%2Flinux-rpi.git HID: lg-g15: make a const array static, makes object smaller Don't populate the const array led_names on the stack but instead make it static. Makes the object code smaller by 79 bytes: Before: text data bss dec hex filename 19686 7952 256 27894 6cf6 drivers/hid/hid-lg-g15.o After: text data bss dec hex filename 19543 8016 256 27815 6ca7 drivers/hid/hid-lg-g15.o (gcc version 10.2.0) Signed-off-by: Colin Ian King Signed-off-by: Jiri Kosina --- diff --git a/drivers/hid/hid-lg-g15.c b/drivers/hid/hid-lg-g15.c index fcaf846..bfbba0d 100644 --- a/drivers/hid/hid-lg-g15.c +++ b/drivers/hid/hid-lg-g15.c @@ -647,7 +647,7 @@ static void lg_g15_input_close(struct input_dev *dev) static int lg_g15_register_led(struct lg_g15_data *g15, int i) { - const char * const led_names[] = { + static const char * const led_names[] = { "g15::kbd_backlight", "g15::lcd_backlight", "g15::macro_preset1",