From: aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>
Date: Sat, 13 Dec 2008 20:41:58 +0000 (+0000)
Subject: Correctly initialize msr list in KVM
X-Git-Tag: TizenStudio_2.0_p2.3.2~208^2~13269
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4c9f7372fcf158d8a5d85ce9ce2988c27be63baf;p=sdk%2Femulator%2Fqemu.git

Correctly initialize msr list in KVM

I believe this was spotted by Gerd Hoffman but I can't find his patch
now.  This will cause very subtle corruption on the heap because we
don't allocate the appropriately sized buffer.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>



git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6017 c046a42c-6fe2-441c-8c8c-71466251a162
---

diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 5e051c5..d8c89ba 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -90,11 +90,11 @@ static int kvm_has_msr_star(CPUState *env)
 
         /* Obtain MSR list from KVM.  These are the MSRs that we must
          * save/restore */
+        msr_list.nmsrs = 0;
         ret = kvm_ioctl(env->kvm_state, KVM_GET_MSR_INDEX_LIST, &msr_list);
         if (ret < 0)
             return 0;
 
-        msr_list.nmsrs = 0;
         kvm_msr_list = qemu_mallocz(sizeof(msr_list) +
                                     msr_list.nmsrs * sizeof(msr_list.indices[0]));
         if (kvm_msr_list == NULL)