From: Guillaume Desmottes <guillaume.desmottes@onestream.live>
Date: Fri, 7 Jul 2023 10:33:37 +0000 (+0200)
Subject: videoflip: fix critical when tag list is not writable
X-Git-Tag: 1.22.7~166
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4c77bc21617d3717bcd677d1fd3dce71713edb2b;p=platform%2Fupstream%2Fgstreamer.git

videoflip: fix critical when tag list is not writable

Fix this pipeline where the tag list is not writable:

gst-launch-1.0 videotestsrc ! taginject tags="image-orientation=rotate-90" ! videoflip video-direction=auto \
  ! autovideosink

GStreamer-CRITICAL **: 12:34:36.310: gst_tag_list_add: assertion 'gst_tag_list_is_writable (list)' failed

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4990>
---

diff --git a/subprojects/gst-plugins-good/gst/videofilter/gstvideoflip.c b/subprojects/gst-plugins-good/gst/videofilter/gstvideoflip.c
index 003a79e..bd7cbeb 100644
--- a/subprojects/gst-plugins-good/gst/videofilter/gstvideoflip.c
+++ b/subprojects/gst-plugins-good/gst/videofilter/gstvideoflip.c
@@ -1791,8 +1791,18 @@ gst_video_flip_sink_event (GstBaseTransform * trans, GstEvent * event)
 
         if (vf->method == GST_VIDEO_ORIENTATION_AUTO) {
           /* update the orientation tag as we rotate the video accordingly */
-          gst_tag_list_add (taglist, GST_TAG_MERGE_REPLACE, "image-orientation",
-              "rotate-0", NULL);
+          if (gst_tag_list_is_writable (taglist)) {
+            gst_tag_list_add (taglist, GST_TAG_MERGE_REPLACE,
+                "image-orientation", "rotate-0", NULL);
+          } else {
+            taglist = gst_tag_list_copy (taglist);
+
+            gst_tag_list_add (taglist, GST_TAG_MERGE_REPLACE,
+                "image-orientation", "rotate-0", NULL);
+
+            gst_event_unref (event);
+            event = gst_event_new_tag (taglist);
+          }
         }
       }
       break;