From: Doug Nazar <nazard@nazar.ca>
Date: Wed, 5 May 2021 00:45:19 +0000 (-0400)
Subject: rtsp-client: fix leak adding headers
X-Git-Tag: 1.19.3~495^2~7
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4c6e57ad33ca99cb3913a96a86c53926ba5abf32;p=platform%2Fupstream%2Fgstreamer.git

rtsp-client: fix leak adding headers

gst_rtsp_message_add_header() makes a copy of the header, instead
of taking ownership.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-rtsp-server/-/merge_requests/204>
---

diff --git a/gst/rtsp-server/rtsp-client.c b/gst/rtsp-server/rtsp-client.c
index 8312e3c..e5a62c0 100644
--- a/gst/rtsp-server/rtsp-client.c
+++ b/gst/rtsp-server/rtsp-client.c
@@ -3018,7 +3018,8 @@ handle_setup_request (GstRTSPClient * client, GstRTSPContext * ctx)
           (gdouble) seekable / GST_SECOND);
 
     gst_rtsp_message_add_header (ctx->response, GST_RTSP_HDR_MEDIA_PROPERTIES,
-        g_string_free (media_properties, FALSE));
+        media_properties->str);
+    g_string_free (media_properties, TRUE);
     /* TODO Check how Accept-Ranges should be filled */
     gst_rtsp_message_add_header (ctx->request, GST_RTSP_HDR_ACCEPT_RANGES,
         "npt, clock, smpte, clock");