From: Wei Yongjun Date: Wed, 4 Sep 2019 14:16:11 +0000 (+0000) Subject: rtlwifi: Fix file release memory leak X-Git-Tag: v5.4-rc1~131^2~61^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4c3e48794dec7cb568974ba3bf2ab62b9c45ca3e;p=platform%2Fkernel%2Flinux-rpi.git rtlwifi: Fix file release memory leak When using single_open() for opening, single_release() should be used instead of seq_release(), otherwise there is a memory leak. This is detected by Coccinelle semantic patch. Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs") Signed-off-by: Wei Yongjun Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/realtek/rtlwifi/debug.c b/drivers/net/wireless/realtek/rtlwifi/debug.c index a051de1..55db71c 100644 --- a/drivers/net/wireless/realtek/rtlwifi/debug.c +++ b/drivers/net/wireless/realtek/rtlwifi/debug.c @@ -88,7 +88,7 @@ static const struct file_operations file_ops_common = { .open = dl_debug_open_common, .read = seq_read, .llseek = seq_lseek, - .release = seq_release, + .release = single_release, }; static int rtl_debug_get_mac_page(struct seq_file *m, void *v)