From: jmm Date: Wed, 27 Nov 2024 08:40:01 +0000 (+0900) Subject: Fix to initialize render effect shader with zero corner radius X-Git-Tag: dali_2.3.52~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4c35710ea5351ed52b0542ac3f68ad6439f41e9c;p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git Fix to initialize render effect shader with zero corner radius Change-Id: I215487b4a4457d958ea38bca6547a7cdbac2ca0d Signed-off-by: jmm --- diff --git a/dali-toolkit/internal/controls/render-effects/blur-effect-impl.cpp b/dali-toolkit/internal/controls/render-effects/blur-effect-impl.cpp index d2a827e008..7e3cabc26f 100644 --- a/dali-toolkit/internal/controls/render-effects/blur-effect-impl.cpp +++ b/dali-toolkit/internal/controls/render-effects/blur-effect-impl.cpp @@ -275,7 +275,7 @@ void BlurEffectImpl::OnActivate() mHorizontalBlurActor.SetProperty(Actor::Property::SIZE, Vector2(downsampledWidth, downsampledHeight)); mVerticalBlurActor.SetProperty(Actor::Property::SIZE, Vector2(downsampledWidth, downsampledHeight)); - // Keep sceneHolder as week handle. + // Keep sceneHolder as weak handle. Integration::SceneHolder sceneHolder = Integration::SceneHolder::Get(ownerControl); if(DALI_UNLIKELY(!sceneHolder)) { @@ -293,7 +293,7 @@ void BlurEffectImpl::OnActivate() Renderer renderer = GetTargetRenderer(); if(mIsBackground) { - renderer.SetProperty(Dali::Renderer::Property::DEPTH_INDEX, Dali::Toolkit::DepthIndex::BACKGROUND - 3); + renderer.SetProperty(Dali::Renderer::Property::DEPTH_INDEX, Dali::Toolkit::DepthIndex::BACKGROUND_EFFECT); } else { diff --git a/dali-toolkit/internal/controls/render-effects/render-effect-impl.cpp b/dali-toolkit/internal/controls/render-effects/render-effect-impl.cpp index c38048e01b..633ce3fba7 100644 --- a/dali-toolkit/internal/controls/render-effects/render-effect-impl.cpp +++ b/dali-toolkit/internal/controls/render-effects/render-effect-impl.cpp @@ -82,6 +82,11 @@ void RenderEffectImpl::SetOwnerControl(Dali::Toolkit::Control control) { mRenderer = CreateRenderer(SHADER_RENDER_EFFECT_VERT, SHADER_RENDER_EFFECT_FRAG); mRenderer.SetProperty(Renderer::Property::BLEND_PRE_MULTIPLIED_ALPHA, true); // Always use pre-multiply alpha + + Shader shader = mRenderer.GetShader(); + shader.RegisterProperty("uCornerRadius", Vector4::ZERO); + shader.RegisterProperty("uCornerSquareness", Vector4::ZERO); + shader.RegisterProperty("uCornerRadiusPolicy", static_cast(1.0f)); } ownerControl.InheritedVisibilityChangedSignal().Connect(this, &RenderEffectImpl::OnControlInheritedVisibilityChanged); diff --git a/dali-toolkit/internal/controls/render-effects/render-effect-impl.h b/dali-toolkit/internal/controls/render-effects/render-effect-impl.h index 39a7abde00..d7656bdb57 100644 --- a/dali-toolkit/internal/controls/render-effects/render-effect-impl.h +++ b/dali-toolkit/internal/controls/render-effects/render-effect-impl.h @@ -126,7 +126,7 @@ protected: /// For sub classes protected: /** - * @brief Initialize sub classes effect + * @brief Initializes sub classes effect */ virtual void OnInitialize() = 0;