From: Benjamin Sherman Date: Thu, 30 May 2019 23:53:48 +0000 (+0000) Subject: staging: mt7621-dma: sizeof via pointer dereference X-Git-Tag: v5.4-rc1~602^2~359 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4c1d2fc7d56cf87a0d399be69e08d5aef73802eb;p=platform%2Fkernel%2Flinux-rpi.git staging: mt7621-dma: sizeof via pointer dereference Pass the size of a struct into kzalloc by pointer dereference. This complies with the Linux kernel coding style and removes the possibility for a bug if the pointer's type is changed. Signed-off-by: Benjamin Sherman Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c index a58725d..60db067 100644 --- a/drivers/staging/mt7621-dma/mtk-hsdma.c +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c @@ -468,7 +468,7 @@ static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy( if (len <= 0) return NULL; - desc = kzalloc(sizeof(struct mtk_hsdma_desc), GFP_ATOMIC); + desc = kzalloc(sizeof(*desc), GFP_ATOMIC); if (!desc) { dev_err(c->device->dev, "alloc memcpy decs error\n"); return NULL;