From: Markus Elfring Date: Wed, 28 Mar 2018 14:34:28 +0000 (+0200) Subject: video: smscufx: Return an error code only as a constant in ufx_realloc_framebuffer() X-Git-Tag: v5.15~6020^2~234 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4befd0cf21cd8ab11f45b9601b37fe8bc91de29f;p=platform%2Fkernel%2Flinux-starfive.git video: smscufx: Return an error code only as a constant in ufx_realloc_framebuffer() * Return an error code without storing it in an intermediate variable. * Delete the label "error" and local variable "retval" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring Cc: Steve Glendinning Signed-off-by: Bartlomiej Zolnierkiewicz --- diff --git a/drivers/video/fbdev/smscufx.c b/drivers/video/fbdev/smscufx.c index 893daeb..abbded6 100644 --- a/drivers/video/fbdev/smscufx.c +++ b/drivers/video/fbdev/smscufx.c @@ -1293,7 +1293,6 @@ static struct fb_ops ufx_ops = { * Assumes no active clients have framebuffer open */ static int ufx_realloc_framebuffer(struct ufx_data *dev, struct fb_info *info) { - int retval = -ENOMEM; int old_len = info->fix.smem_len; int new_len; unsigned char *old_fb = info->screen_base; @@ -1310,7 +1309,7 @@ static int ufx_realloc_framebuffer(struct ufx_data *dev, struct fb_info *info) new_fb = vmalloc(new_len); if (!new_fb) { pr_err("Virtual framebuffer alloc failed"); - goto error; + return -ENOMEM; } if (info->screen_base) { @@ -1323,11 +1322,7 @@ static int ufx_realloc_framebuffer(struct ufx_data *dev, struct fb_info *info) info->fix.smem_start = (unsigned long) new_fb; info->flags = smscufx_info_flags; } - - retval = 0; - -error: - return retval; + return 0; } /* sets up I2C Controller for 100 Kbps, std. speed, 7-bit addr, master,