From: Jaeyun Jung <jy1210.jung@samsung.com>
Date: Tue, 2 May 2023 07:51:28 +0000 (+0900)
Subject: [CodeClean] remove unnecessary code
X-Git-Tag: accepted/tizen/unified/20230609.163739~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4bedb21c597c56272d31eee13611d8dea5b97ebc;p=platform%2Fupstream%2Fnnstreamer-edge.git

[CodeClean] remove unnecessary code

Code clean, fix indent and remove unnecessary lines.

Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
---

diff --git a/src/libnnstreamer-edge/nnstreamer-edge-internal.c b/src/libnnstreamer-edge/nnstreamer-edge-internal.c
index d389325..3857249 100644
--- a/src/libnnstreamer-edge/nnstreamer-edge-internal.c
+++ b/src/libnnstreamer-edge/nnstreamer-edge-internal.c
@@ -22,16 +22,14 @@
 #include "nnstreamer-edge-aitt.h"
 #include "nnstreamer-edge-mqtt.h"
 
-#ifndef PTHREAD_CREATE_JOINABLE
-#define PTHREAD_CREATE_JOINABLE 0
-#endif
-
 #ifndef MSG_NOSIGNAL
 #define MSG_NOSIGNAL 0
 #endif
 
+/**
+ * @brief The maximum length of pending connections to accept socket.
+ */
 #define N_BACKLOG 10
-#define DEFAULT_TIMEOUT_SEC 10
 
 /**
  * @brief Data structure for edge handle.
@@ -169,11 +167,7 @@ _set_socket_option (int fd)
 static bool
 _fill_socket_addr (struct sockaddr_in *saddr, const char *host, const int port)
 {
-  /**
-   * @todo handle protocol
-   * 1. support edge connection type (TCP/UDP)
-   * 2. ipv4 and ipv6
-   */
+  /** @todo handle protocol (ipv4 and ipv6) */
   saddr->sin_family = AF_INET;
   saddr->sin_port = htons (port);
 
diff --git a/src/libnnstreamer-edge/nnstreamer-edge-mqtt.h b/src/libnnstreamer-edge/nnstreamer-edge-mqtt.h
index df0a662..7ef2532 100644
--- a/src/libnnstreamer-edge/nnstreamer-edge-mqtt.h
+++ b/src/libnnstreamer-edge/nnstreamer-edge-mqtt.h
@@ -55,8 +55,7 @@ bool nns_edge_mqtt_is_connected (nns_edge_broker_h broker_h);
 /**
  * @brief Get message from mqtt broker with within timeout. (0 for inifinite timeout)
  */
-int
-nns_edge_mqtt_get_message (nns_edge_broker_h broker_h, void **msg, nns_size_t * msg_len,  unsigned int timeout);
+int nns_edge_mqtt_get_message (nns_edge_broker_h broker_h, void **msg, nns_size_t *msg_len, unsigned int timeout);
 
 /**
  * @brief Internal util function to send edge-data via MQTT connection.
diff --git a/tests/unittest_nnstreamer-edge.cc b/tests/unittest_nnstreamer-edge.cc
index df6b809..f644691 100644
--- a/tests/unittest_nnstreamer-edge.cc
+++ b/tests/unittest_nnstreamer-edge.cc
@@ -2092,7 +2092,7 @@ TEST(edgeDataSerialize, normal)
   ret = nns_edge_data_destroy (dest_h);
   EXPECT_EQ (ret, NNS_EDGE_ERROR_NONE);
 
-  SAFE_FREE(serialized_data);
+  SAFE_FREE (serialized_data);
 }
 
 
@@ -3583,7 +3583,7 @@ TEST(edgeQueue, pushInvalidParam03_n)
 
   EXPECT_TRUE (nns_edge_queue_destroy (queue_h));
 
-  SAFE_FREE(data);
+  SAFE_FREE (data);
 }
 
 /**