From: Bruce Allan Date: Tue, 31 Jan 2012 06:37:59 +0000 (+0000) Subject: e1000e: remove test that is always false X-Git-Tag: v3.4-rc1~177^2~341 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4bcf053baf6b255e8c82c7ecd0d15954adb0379b;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git e1000e: remove test that is always false warning: comparison of unsigned expression < 0 is always false Remove an unnecessary test that is reported when compiling driver with W=1. The test is unnecessary because Intel wired GbE hardware older (i.e. less) than 82571 is not supported by this driver. Signed-off-by: Bruce Allan Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- diff --git a/drivers/net/ethernet/intel/e1000e/mac.c b/drivers/net/ethernet/intel/e1000e/mac.c index e1cf107..33d1b9e 100644 --- a/drivers/net/ethernet/intel/e1000e/mac.c +++ b/drivers/net/ethernet/intel/e1000e/mac.c @@ -174,8 +174,8 @@ s32 e1000_check_alt_mac_addr_generic(struct e1000_hw *hw) if (ret_val) goto out; - /* not supported on older hardware or 82573 */ - if ((hw->mac.type < e1000_82571) || (hw->mac.type == e1000_82573)) + /* not supported on 82573 */ + if (hw->mac.type == e1000_82573) goto out; ret_val = e1000_read_nvm(hw, NVM_ALT_MAC_ADDR_PTR, 1,