From: Christoph Hellwig Date: Mon, 8 Mar 2021 07:45:48 +0000 (+0100) Subject: paride/pd: remove ->revalidate_disk X-Git-Tag: v5.15~1258^2~69 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4bae7afdd789baedbc0b82a4b9ef51501dd7d4fe;p=platform%2Fkernel%2Flinux-starfive.git paride/pd: remove ->revalidate_disk ->revalidate_disk is only called during add_disk for pd, but at that point the driver has already set the capacity to the one returned from Identify a little earlier, so this additional update is entirely superflous. Signed-off-by: Christoph Hellwig Link: https://lore.kernel.org/r/20210308074550.422714-2-hch@lst.de Signed-off-by: Jens Axboe --- diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c index 897acda..828a45f 100644 --- a/drivers/block/paride/pd.c +++ b/drivers/block/paride/pd.c @@ -859,16 +859,6 @@ static unsigned int pd_check_events(struct gendisk *p, unsigned int clearing) return r ? DISK_EVENT_MEDIA_CHANGE : 0; } -static int pd_revalidate(struct gendisk *p) -{ - struct pd_unit *disk = p->private_data; - if (pd_special_command(disk, pd_identify) == 0) - set_capacity(p, disk->capacity); - else - set_capacity(p, 0); - return 0; -} - static const struct block_device_operations pd_fops = { .owner = THIS_MODULE, .open = pd_open, @@ -877,7 +867,6 @@ static const struct block_device_operations pd_fops = { .compat_ioctl = pd_ioctl, .getgeo = pd_getgeo, .check_events = pd_check_events, - .revalidate_disk= pd_revalidate }; /* probing */