From: Ben Noordhuis Date: Wed, 24 Oct 2012 22:52:15 +0000 (+0200) Subject: v8: remove optimization switches X-Git-Tag: v0.8.13~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4b8629db3717a587a44b373cd10351e005b190f3;p=platform%2Fupstream%2Fnodejs.git v8: remove optimization switches Remove compiler switches from $(TOPLEVEL)/deps/v8/build/common.gypi, we set them globally in $(TOPLEVEL)/common.gypi. Commit 29d12c73 accidentally reintroduced the switches again. In particular, the 'cflags!': ['-O2','-Os'] section forced building V8 without any optimizations, resulting in a steep (~66%) performance drop on some benchmarks. Fixes #4191. --- diff --git a/deps/v8/build/common.gypi b/deps/v8/build/common.gypi index 5d6132c..7b8a32b 100644 --- a/deps/v8/build/common.gypi +++ b/deps/v8/build/common.gypi @@ -339,16 +339,6 @@ 'conditions': [ ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="netbsd" \ or OS=="android"', { - 'cflags!': [ - '-O2', - '-Os', - ], - 'cflags': [ - '-fdata-sections', - '-ffunction-sections', - '-fomit-frame-pointer', - '-O3', - ], 'conditions': [ [ 'gcc_version==44 and clang==0', { 'cflags': [