From: Christophe JAILLET Date: Sat, 15 Jan 2022 07:33:26 +0000 (+0100) Subject: dmaengine: iot: Remove useless DMA-32 fallback configuration X-Git-Tag: v6.6.17~7851^2~19 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4ae7094011bea9c1d5b2ea9d3d4d640b394e9630;p=platform%2Fkernel%2Flinux-rpi.git dmaengine: iot: Remove useless DMA-32 fallback configuration As stated in [1], dma_set_mask() with a 64-bit mask never fails if dev->dma_mask is non-NULL. So, if it fails, the 32 bits case will also fail for the same reason. Simplify code and remove some dead code accordingly. [1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/1d0de79852a3551545fe896789a75b36e35db8e6.1642231987.git.christophe.jaillet@wanadoo.fr Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c index 373b8da..5d707ff 100644 --- a/drivers/dma/ioat/init.c +++ b/drivers/dma/ioat/init.c @@ -1365,8 +1365,6 @@ static int ioat_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); if (err) - err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); - if (err) return err; device = alloc_ioatdma(pdev, iomap[IOAT_MMIO_BAR]);