From: Randy Dunlap Date: Fri, 8 Aug 2008 03:33:19 +0000 (-0700) Subject: bnx2x: fix logical op X-Git-Tag: v2.6.27-rc3~69^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4ab84d450e24b3a309608182a8d8e30626b46f8f;p=platform%2Fkernel%2Flinux-3.10.git bnx2x: fix logical op Fix dubious logical operation that was found by sparse: linux-next-20080807/drivers/net/bnx2x_main.c:7205:27: warning: dubious: !x & y Signed-off-by: Randy Dunlap Signed-off-by: David S. Miller --- diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c index af251a5..272a4bd 100644 --- a/drivers/net/bnx2x_main.c +++ b/drivers/net/bnx2x_main.c @@ -7202,7 +7202,7 @@ static void __devinit bnx2x_link_settings_requested(struct bnx2x *bp) bp->link_params.req_flow_ctrl = (bp->port.link_config & PORT_FEATURE_FLOW_CONTROL_MASK); if ((bp->link_params.req_flow_ctrl == FLOW_CTRL_AUTO) && - (!bp->port.supported & SUPPORTED_Autoneg)) + !(bp->port.supported & SUPPORTED_Autoneg)) bp->link_params.req_flow_ctrl = FLOW_CTRL_NONE; BNX2X_DEV_INFO("req_line_speed %d req_duplex %d req_flow_ctrl 0x%x"