From: Amir Goldstein <amir73il@gmail.com>
Date: Mon, 24 Apr 2017 19:26:40 +0000 (+0300)
Subject: ovl: do not set overlay.opaque on non-dir create
X-Git-Tag: v4.12-rc1~41^2~10
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4a99f3c83dc493c8ea84693d78cd792839c8aa64;p=platform%2Fkernel%2Flinux-exynos.git

ovl: do not set overlay.opaque on non-dir create

The optimization for opaque dir create was wrongly being applied
also to non-dir create.

Fixes: 97c684cc9110 ("ovl: create directories inside merged parent opaque")
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Cc: <stable@vger.kernel.org> # v4.10
---

diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
index 6515796..bfabc65 100644
--- a/fs/overlayfs/dir.c
+++ b/fs/overlayfs/dir.c
@@ -210,7 +210,7 @@ static int ovl_create_upper(struct dentry *dentry, struct inode *inode,
 	if (err)
 		goto out_dput;
 
-	if (ovl_type_merge(dentry->d_parent)) {
+	if (ovl_type_merge(dentry->d_parent) && d_is_dir(newdentry)) {
 		/* Setting opaque here is just an optimization, allow to fail */
 		ovl_set_opaque(dentry, newdentry);
 	}