From: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Date: Wed, 16 Aug 2023 10:55:24 +0000 (+0200)
Subject: tty: tty_buffer: warn if losing flags in __tty_insert_flip_string_flags()
X-Git-Tag: v6.6.7~2018^2~53
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4a8d99a409d3d194527674a896362992a171cd7b;p=platform%2Fkernel%2Flinux-starfive.git

tty: tty_buffer: warn if losing flags in __tty_insert_flip_string_flags()

And add a WARN_ON_ONCE(need_flags) to make sure we are not losing flags
in __tty_insert_flip_string_flags().

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230816105530.3335-5-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
index 94a88dc..c101b4a 100644
--- a/drivers/tty/tty_buffer.c
+++ b/drivers/tty/tty_buffer.c
@@ -325,6 +325,9 @@ int __tty_insert_flip_string_flags(struct tty_port *port, const u8 *chars,
 			flags += space;
 		} else if (tb->flags) {
 			memset(flag_buf_ptr(tb, tb->used), flags[0], space);
+		} else {
+			/* tb->flags should be available once requested */
+			WARN_ON_ONCE(need_flags);
 		}
 
 		tb->used += space;